Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add NetworkService::add_known_address #8467

Merged
2 commits merged into from
Mar 26, 2021

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 26, 2021

This functionality exists but wasn't exposed in the API of NetworkService.

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 26, 2021
@tomaka tomaka requested a review from eskimor March 26, 2021 16:04
@tomaka
Copy link
Contributor Author

tomaka commented Mar 26, 2021

bot merge

@ghost
Copy link

ghost commented Mar 26, 2021

Waiting for commit status.

@ghost ghost merged commit e3a864a into paritytech:master Mar 26, 2021
@tomaka tomaka deleted the expose-add-known-addr branch March 26, 2021 17:49
rphmeier pushed a commit that referenced this pull request Mar 28, 2021
ordian added a commit that referenced this pull request Mar 31, 2021
* master: (84 commits)
  Duplicate logging to stdout (#8495)
  Fix sync restart (#8497)
  client: fix justifications migration (#8489)
  helper macro to create storage types on the fly (#8456)
  Make `BlockImport` and `Verifier` async (#8472)
  Get rid of `test-helpers` feature in sc-consensus-babe (#8486)
  Enhancement on Substrate Node Template (#8473)
  Add Social Network (#8065)
  Prepare UI tests for Rust 1.51 & new CI image (#8474)
  Benchmarking pallet-example (#8301)
  Use pathbuf for remote externalities (#8480)
  Bring back the on_finalize weight of staking. (#8463)
  Implement `fungible::*` for Balances (#8454)
  make types within `generate_solution_type` macro explicit (#8447)
  [pallet-staking] Refund unused weight for `payout_stakers` (#8458)
  Use `async_trait` in sc-consensus-slots (#8461)
  Repot frame_support::traits; introduce some new currency stuff (#8435)
  Fix &mut self -> &self in add_known_address (#8468)
  Add NetworkService::add_known_address (#8467)
  Fix companion check (#8464)
  ...
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants